Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Vista Aero border problem #58

Closed
shawnpxtl opened this issue May 2, 2022 · 5 comments
Closed

Windows Vista Aero border problem #58

shawnpxtl opened this issue May 2, 2022 · 5 comments

Comments

@shawnpxtl
Copy link

There are only three sides of the Aero effrct border under the window, and the above is not rendered by the Aero effect (I don't know if FireFox does it intentionally), but displays a style similar to Windows 10
新建位图图像

@gdl-blue
Copy link

gdl-blue commented May 2, 2022

In menu-cusomize, check title bar. It will partially fix it but the tab bar is still not glassed

(I always used Firefox with title bar on, whether there is a bug or not)

@1280px
Copy link
Collaborator

1280px commented May 3, 2022

It probably happens because Firefox's CSS doesn't have support for Vista as is wasn't ever intended to be launched on it, and it simply counts Vista as 10 because it's not Win 7 and 8.

You'll need to tinker with CSS a little... What I think can be done is go to
https://github.com/Feodor2/Mypal68/blob/main/browser/themes/windows/browser.css
https://github.com/Feodor2/Mypal68/blob/main/browser/themes/windows/browser-aero.css
https://github.com/Feodor2/Mypal68/blob/main/browser/themes/windows/compacttheme.css
these files (I might miss some but these are main ones),

find Windows 7 @media in Mozilla's CSS files (sth like this: @media (-moz-platform: windows-win7) ) and add windows-vista; before so the thing will look sth like @media (-moz-platform: windows-vista; windows-win7).

_
Alternatively, you can try to "fix" it without recompiling using userChrome.css.
r/firefoxCSS wiki on Reddit is a great place to learn the basics. You'll have to copy all CSS aforementioned rules from the CSS files above and replace windows-win7 with windows-vista. This should probably work too

@1280px
Copy link
Collaborator

1280px commented May 5, 2022

find Windows 7 @media in Mozilla's CSS files (sth like this: @media -moz-platform: windows-win7) ) and add windows-vista; before so the thing will look sth like @media (-moz-platform: windows-vista; windows-win7)

nvm, I did a few experiments and I see the issue now. Mozilla deleted "windows-vista" and "windows-xp" media queries in FF57, so the method above won't work.

The solution I came up with is to use -moz-windows-glass, which is only triggered by Windows Vista and 7, when Aero Glass is enabled. Pay attention this method will not work if you're using Vista with Aero Basic theme (which still looks pretty good).

You can get modified CSS files here:
https://github.com/1280px/Mypal68_AeroVista/commits/main

Also I made a pull request (tested on Windows XP, Windows Vista and Windows 7):
#63

@Feodor2
Copy link
Owner

Feodor2 commented May 5, 2022

I shall look into this after resolving major issues like crashes.

@win98se
Copy link

win98se commented Sep 2, 2022

I suggest that this issue is to be closed because it is solved by #63. Thank you, @1280px!

image

@Feodor2 Feodor2 closed this as completed Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants